Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing whitespace #638

Merged
merged 2 commits into from Nov 7, 2016
Merged

Conversation

@lazysoundsystem
Copy link
Contributor

lazysoundsystem commented Nov 6, 2016

Following up on #636 (though I added an extra space in the search expression on that ticket), this removes trailing whitespace as per the contribution guidelines.

Checking with git diff -w shows that nothing else has been changed.

Thanks for vimperator!

@@ -181,7 +181,7 @@
</p>

<code><![CDATA[
var INFO =
var INFO =

This comment has been minimized.

Copy link
@timss

timss Nov 6, 2016

Member

Could this whitespace be intentional, or have any effect on the breakline?

@timss
Copy link
Member

timss commented Nov 6, 2016

Thanks for your contribution. Left a comment, but other than that it looks good.

The changes are somewhat disruptive to the change history of quite a few core files, wouldn't want to repeat this process too often. I take it this is maybe automated and complete (for now)? :-)

@soredake
Copy link
Contributor

soredake commented Nov 6, 2016

@lazysoundsystem
Copy link
Contributor Author

lazysoundsystem commented Nov 7, 2016

Updated the patch by reinstating the spaces within CDATA.

I believe this is complete - grep -nr "[[:space:]]\$" . - There's no need to merge this patch, I just thought I ought to follow up on my comment on the other PR.

And thanks for sharing editorconfig - looks useful!

By the way, unrelated to this I did notice a reference to "trac" in vimperator/locale/ja/intro.xml and to "googlecode" in vimperator/locale/en-US/intro.xml . Perhaps those need updating.

@timss
Copy link
Member

timss commented Nov 7, 2016

Thanks. Merging.

Yeah, those references need to be fixed and/or removed. Thanks for the heads up. One of them even points to an AUTHORS file which hasn't been updated since 2010 (authors generated based on git log/github is better a nyway).

@timss timss merged commit b9c1f0d into vimperator:master Nov 7, 2016
lazysoundsystem added a commit to lazysoundsystem/vimperator-labs that referenced this pull request Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.