You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It should be fixed by changing matchingUrls to /\.pdf\?([^=]+=[^&]*)?(&[^=]+=[^&]*)*$/.
Further more, can we support something like filetype and ftdetec in vim? Currently, vimperator can only addUserMap by matchingUrls. Is it possible to support to match DOMs to decide which settings should be enabled?
The text was updated successfully, but these errors were encountered:
fno2010
added a commit
to fno2010/vimperator-plugins
that referenced
this issue
Dec 28, 2016
Shall we reopen this issue or start another issue for discussion? Because I found matchingUrls is really not a good idea to autoload plugins.
In the dynamic websites, http servers will use route to select which pages should be rendered. So URL does often not direct a static file.
For example, https://github.com/<user>/<repo>/blob/<branch>/<path>/<whatever>.pdf will not direct a PDF file. Github will open a webpage with its own online pdf reader to display this PDF file. So PDF.js will not be loaded by FireFox.
But https://raw.githubusercontent.com/<user>/<repo>/<branch>/<path>/<whatever>.pdf will response a PDF file via HTTPS. The media type of its HTTPS response is application/pdf. So FireFox will load PDF.js.
When accessing urls like following, PDF.js.js cannot be loaded:
It should be fixed by changing
matchingUrls
to/\.pdf\?([^=]+=[^&]*)?(&[^=]+=[^&]*)*$/
.Further more, can we support something like
filetype
andftdetec
in vim? Currently, vimperator can onlyaddUserMap
bymatchingUrls
. Is it possible to support to match DOMs to decide which settings should be enabled?The text was updated successfully, but these errors were encountered: