Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cookieManager.js for Firefox 46 #101

Merged
merged 1 commit into from May 23, 2016
Merged

Fix cookieManager.js for Firefox 46 #101

merged 1 commit into from May 23, 2016

Conversation

kaorimatz
Copy link
Contributor

Firefox 46 removed legacy array/generator comprehension.

https://bugzilla.mozilla.org/show_bug.cgi?id=1220564

This relates to #99 and #100.

@kaorimatz
Copy link
Contributor Author

Removing and listing cookie permissions with -perm option does not work properly due to the API changes in nsIPermission and nsIPermissionManager. I will submit another PR to fix this.

@Jagua Jagua merged commit cc87177 into vimpr:master May 23, 2016
@Jagua
Copy link
Member

Jagua commented May 23, 2016

Thank you.

@kaorimatz kaorimatz deleted the cookiemanager-ff46 branch May 24, 2016 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaorimatz @Jagua