Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VimwikiGenerateTags links don't handle file hierarchy correctly #794

Closed
jean opened this issue Jan 2, 2020 · 2 comments
Closed

VimwikiGenerateTags links don't handle file hierarchy correctly #794

jean opened this issue Jan 2, 2020 · 2 comments
Labels
bug tag Related to tag system

Comments

@jean
Copy link

jean commented Jan 2, 2020

Create a tag (e.g. :SomeTag:), rebuild tags, and in diary/2020-01-02.wiki issue the command :VimwikiGenerateTags.

  • This results in links like [[diary/2020-01-02#SomeTag]]. When that link is followed, vim tries to create diary/diary/2020-01-02.wiki. This is wrong:
    • either links should be generated based on the main wiki directory (like [[/diary/2020-01-02#SomeTag]]),
    • or (better) they should be generated relative to the file in which the :VimwikiGenerateTags command is issued ([[2020-01-02#SomeTag]]).

This is a follow-on from #190.


Syntax: default.

From .vimrc:

let wiki = {}
let wiki.name = 'wiki'
let wiki.path = '~/wiki/'
let wiki.nested_syntaxes = nested_syntaxes
let wiki.auto_tags = 1

The output of :VimwikiShowVersion.

Branch: dev
Revision: 5cdeb9a
Date: 2020-01-01 10:58:56 -0700

@ranebrown ranebrown added the bug label Jan 3, 2020
@ranebrown
Copy link
Contributor

Might be able to use vimwiki#path#relpath(dir, file) to fix this.

@tinmarino tinmarino added the tag Related to tag system label Jul 24, 2020
@tinmarino tinmarino added this to Needs triage in Bug Triage Deprecated via automation Jul 24, 2020
@tinmarino tinmarino moved this from Needs triage to Low priority in Bug Triage Deprecated Jul 24, 2020
RonMcKay added a commit to RonMcKay/vimwiki that referenced this issue Aug 20, 2021
Also add a vader test case and update the changelog as well as the list
of contributors.
RonMcKay added a commit to RonMcKay/vimwiki that referenced this issue Aug 20, 2021
Also add a vader test case and update the changelog as well as the list
of contributors.
tinmarino added a commit that referenced this issue Dec 18, 2021
Also add a vader test case and update the changelog as well as the list
of contributors.

Co-authored-by: Tinmarino <tinmarino@gmail.com>
@tinmarino
Copy link
Member

Fixed #1162

Bug Triage Deprecated automation moved this from Low priority to Closed Dec 18, 2021
jls83 pushed a commit to jls83/vimwiki that referenced this issue Jan 17, 2023
Also add a vader test case and update the changelog as well as the list
of contributors.

Co-authored-by: Tinmarino <tinmarino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tag Related to tag system
Projects
Development

No branches or pull requests

3 participants