Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:VimwikiGoto tab completion only works when written in-line, not when called from \wn #913

Closed
igor-kupczynski opened this issue Jun 14, 2020 · 1 comment
Assignees

Comments

@igor-kupczynski
Copy link

PR #785 adds completion to :VimwikiGoto, however it works only when you try to type the filename after the command, e.g.

Say I have a file called Hammerspoon.md

:VimwikiGoto Hamm<tab>    # ✅  shows the completion pop-up

It doesn't work when called like that:

:VimwikiGoto<ret>
Hamm<tab>                  # ❌ shows `Hamm^I` (see below)

image

This is more problematic when used together with the <Leader>wn keyboard shortcut because it acts like the second, broken way.

It would be nice to improve the completion.

Env

$ nvim --version
NVIM v0.4.3
:VimwikiShowVersion
Stable version: 2.5
call minpac#add('vimwiki/vimwiki')
let g:vimwiki_list = [
    \ {'path': '~/Notes', 'syntax': 'markdown', 'ext': '.md', 'index': 'README'},
.. other wikis here
    \ }
    \ ]
@tinmarino tinmarino self-assigned this Jul 21, 2020
tinmarino added a commit that referenced this issue Jul 21, 2020
Issue #913:
        :VimwikiGoto tab completion only works when written in-line, not when called from \wn #913
        PR #785 adds completion to :VimwikiGoto, however it works only when you try to type the filename after the command, e.g.
@tinmarino
Copy link
Member

Fixed: 75a9232
<- input() is taking the completion desired as argument
-> wanna see my dirty face ->

function! vimwiki#base#goto(...) abort
  let key = a:0 > 0 ? a:1 : input('Enter name: ', '',
        \ 'customlist,vimwiki#base#complete_links_escaped')

Thanks for the feedback

deepredsky pushed a commit to deepredsky/vimwiki that referenced this issue Jan 16, 2021
Issue vimwiki#913:
        :VimwikiGoto tab completion only works when written in-line, not when called from \wn vimwiki#913
        PR vimwiki#785 adds completion to :VimwikiGoto, however it works only when you try to type the filename after the command, e.g.
jls83 pushed a commit to jls83/vimwiki that referenced this issue Jan 17, 2023
Issue vimwiki#913:
        :VimwikiGoto tab completion only works when written in-line, not when called from \wn vimwiki#913
        PR vimwiki#785 adds completion to :VimwikiGoto, however it works only when you try to type the filename after the command, e.g.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants