Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Renaming and HTML Exporting Issue #1057

Merged
merged 13 commits into from
Feb 5, 2021
Merged

Fix Renaming and HTML Exporting Issue #1057

merged 13 commits into from
Feb 5, 2021

Conversation

levirs565
Copy link
Contributor

@levirs565 levirs565 commented Nov 21, 2020

Steps for submitting a pull request:

  • ALL pull requests should be made against the dev branch!
  • Take a look at CONTRIBUTING.MD
  • Reference any related issues.
  • Provide a description of the proposed changes.
  • PRs must pass Vint tests and add new Vader tests as applicable.
  • Make sure to update the documentation in doc/vimwiki.txt if applicable,
    including the Changelog and Contributors sections.

This pull request fix these bugs:

  • Renaming, Updating Link, and HTML Export in Windows. This fixed by using nicer way to getting sudbir.
  • Custom HTML Shell execution escaping failed in Windows when in root dir.
  • Custom HTML CSS path is wrong.

@levirs565 levirs565 changed the title Fix Remaing and HTML Exporting Issue Fix Renaming and HTML Exporting Issue Nov 21, 2020
@levirs565
Copy link
Contributor Author

Before this Pull Request merged we must confirm that referenced Issue is fixed or not

@tinmarino
Copy link
Member

Please ping me when ready.

@levirs565
Copy link
Contributor Author

You can merge this PR

@levirs565
Copy link
Contributor Author

This Pull Request is Ready for Merging

@tinmarino
Copy link
Member

Merging: I do not have time to test it on Windows but it does not break the currents test battery.
Marked the related issues to be closed before v2.6.

@levirs565 you may send some examples of situations where there were bugs formerly so that we can add some non-regression tests. One day Windows platform may be included in those tests (it is supported by Travis)

@tinmarino tinmarino merged commit 61a6ce6 into vimwiki:dev Feb 5, 2021
jls83 pushed a commit to jls83/vimwiki that referenced this pull request Jan 17, 2023
On Windows.

Commits squashed from first to be committed to most recent:
* fix subdir not correct when path using `\`

* fix slice by variable value not supported in vim 7.3

* remove last '\' from path in CustomWiki2HTML

* fix CSS path in CustomWiki2HTML wrong

* remove unused confirm CustomWiki2HTML

* use ==# rather than == in shellescape html.vim

* remove "FIXME this can terminate in the middle of a path component! from
base#subdir

* update doc/vimwiki.txt

* update contributor to doc/vimwiki.txt

* add comment in html#shellescape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants