Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VimwikiGoto: Support wiki pages with spaces #1128

Merged
merged 1 commit into from
May 20, 2021
Merged

VimwikiGoto: Support wiki pages with spaces #1128

merged 1 commit into from
May 20, 2021

Conversation

sstallion
Copy link
Contributor

@sstallion sstallion commented May 20, 2021

This PR updates :VimwikiGoto to support opening wiki pages with spaces in the name.

@tinmarino
Copy link
Member

tinmarino commented May 20, 2021

Perfect to me:

Just one byte to replace the parameters command from by so that argument is quoted, anyway only the first argument is considered.

But this one byte is consolidated by nice test.
Thank you @sstallion

Can someone else please merge (rebase better say): @brennen , @chipsenkbeil ?

@chipsenkbeil
Copy link
Member

I'm not that familiar with <q-args> versus <f-args>. Reading through the documentation, it sounds like <q-args> will produce a single argument whereas <f-args> breaks up by the space. The actual impl of vimwiki#base#goto only uses the first argument as part of the full path and an optional second argument as the anchor, so I think the above change makes sense and works better.

Since none of the tests fail, we can give this a go.

@chipsenkbeil chipsenkbeil merged commit 8fef79b into vimwiki:dev May 20, 2021
jls83 pushed a commit to jls83/vimwiki that referenced this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants