Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to conceal preformatted text markers #641

Closed
wants to merge 3 commits into from
Closed

Add an option to conceal preformatted text markers #641

wants to merge 3 commits into from

Conversation

gpanders
Copy link

This PR adds a feature allowing users to conceal code fence markers.

For example, if you have the following in your wiki:

Some text

{{{python
def hello_world():
    print("Hello world!")
}}}

then setting g:vimwiki_conceal_code_blocks would conceal the {{{python and }}} lines to produce:

Some text


def hello_world():
    print("Hello world!")

This can make things look a lot nicer and more polished in wikis with many code blocks.

Note that this only applies to blocks that are syntax highlighted. So plain blocks that use just {{{ }}} (with no syntax highlighting) will not be concealed.

@hq6 hq6 self-assigned this Mar 27, 2019
@hq6
Copy link
Contributor

hq6 commented Mar 27, 2019

Please fix the conflicts and force-push.

Also, what is the reasoning for handling syntax highlighted blocks differently than other pre-formatted text?

@gpanders
Copy link
Author

No particular reason, I can modify it to include all pre-formatted text.

@gpanders gpanders changed the title Add an option to conceal code blocks Add an option to conceal preformatted text markers Mar 27, 2019
@gpanders
Copy link
Author

Conflicts have been resolved. This is ready for merge.

hq6 pushed a commit that referenced this pull request Mar 28, 2019
@hq6
Copy link
Contributor

hq6 commented Mar 28, 2019

I have manually merged this in e56c26c7ba892fc6ee073df0f2457d899d24d433 to have a cleaner history.

@hq6 hq6 closed this Mar 28, 2019
@ranebrown ranebrown added this to Done in v2.5 Release Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v2.5 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants