Add html_filename_parameterization option. #665
Conversation
|
@patrickdavey Overall this looks pretty good. The only changes I see off the top of my head are to update the changelog and add a link to your It might make sense to add a short section like done here with a brief overview of your project and the link. It will probably be a few days before I get to any testing with this. |
|
Updated the docs with the link to project + changelog section. |
|
Seems good. The only thing I wonder about: I guess that sooner or later someone will asks for an option to convert spaces to underscore instead of to a dash. What's our plan for that? Use '2' for this variant? |
|
@Nudin This is for integration with vimwiki_markdown to convert markdown syntax files to html. It doesn't really have a use outside of that currently so I don't think that we need to worry about adding another variant. |
|
@patrickdavey I tested this and I don't see any issues. I think it would make sense to slightly modify the help description of the documentation to say it prevents the html files from being regenerated every time conversion is done. After that I think its good to merge! |
This adds the vimwiki_local `html_filename_parameterization` option (0|1) which performs the same sanitization of filenames as does the vimwiki_markdown gem. For example, if your file is called "My File.md" it will be written out as "my-file.html". If the html_filename_parameterization options is enabled, we also _do not delete_ non-matching html files when the VimwikiAllToHtml command is run. Closes vimwiki#129
|
@ranebrown I've altered the text slightly - see Lines 2445 to 2449 in 5f01182 If you want it changed again, can you just let me know what you'd like and I'll put it in there (or just merge it and then change it to what you like) |
This adds the vimwiki_local
html_filename_parameterizationoption (0|1)which performs the same sanitization of filenames as does the vimwiki_markdown gem.
For example, if your file is called "My File.md" it will be written out
as "my-file.html".
If the html_filename_parameterization options is enabled, we also do
not delete non-matching html files when the VimwikiAllToHtml command is run.
Closes #129