Fix conceallevel setted globally instead of locally #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinmarino
reviewed
Jun 1, 2020
There was a problem hiding this comment.
Thanks @PtitCaius !
Very good collaboration: as little change as possible and the desired feature is obtained.
tinmarino
approved these changes
Jun 1, 2020
PtitCaius
changed the title
tinmarino
reviewed
Jun 1, 2020
doc/vimwiki.txt
Outdated
| @@ -3521,7 +3521,8 @@ Contributors and their Github usernames in roughly chronological order: | |||
| - Samir Benmendil (@Ram-Z) | |||
| - Stefan Lehmann (@stevesteve) | |||
| - @graywolf | |||
| - flex (@bratekarate) | |||
| - flex (@bratekarate)* | |||
There was a problem hiding this comment.
Why a star here: is he a rock star ?
There was a problem hiding this comment.
Oops, just a typo I've made ! Sorry
REmove the star at flex
tinmarino
approved these changes
Jun 1, 2020
|
Perfect, I'll add some non-regression test. |
You're welcome ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The conceallevel option is now setted locally when entering a vimwiki buffer instead of globally
Closes #899