Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds email style quotes to signal blockquotes #901

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Adds email style quotes to signal blockquotes #901

merged 4 commits into from
Jul 22, 2020

Conversation

eltrufas
Copy link
Contributor

@eltrufas eltrufas commented Jun 3, 2020 •
edited

fixes #422

Adds a new function to the html converter to detect blocks of text prefixed with '>' and treats them as a blockquote.

Steps for submitting a pull request:

  • ALL pull requests should be made against the dev branch!
  • Take a look at CONTRIBUTING.MD
  • Reference any related issues.
  • Provide a description of the proposed changes.
  • PRs must pass Vint tests and add new Vader tests as applicable.
  • Make sure to update the documentation in doc/vimwiki.txt if applicable,
    including the Changelog and Contributors sections.

@eltrufas eltrufas force-pushed the arrow-blockquotes branch 6 times, most recently from fe81db2 to 8ac3648 Compare June 4, 2020 04:08
@Nudin Nudin added this to In progress in v2.6 Jun 5, 2020
ghost
ghost reviewed Jun 14, 2020
View reviewed changes
doc/vimwiki.txt Outdated Show resolved Hide resolved
@tinmarino
Copy link
Member

Sorry, I cannot review this one: I don't use html convertion.
But if you add test and they works, I can trust you and just click on "merge" button.

@tinmarino tinmarino added the test-needed Add a non-regression test label Jun 16, 2020
@eltrufas eltrufas force-pushed the arrow-blockquotes branch 2 times, most recently from 0b3b457 to 6e95c6f Compare June 18, 2020 03:53
tinmarino
tinmarino approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@tinmarino tinmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@tinmarino
Copy link
Member

Sorry I just realize that I was waiting a little for potential changes from you or comments from other.

And I forgot I had to click on Merge button even if I have one of the best Todo, Note taking App.

Excelent PR: should be a model for students

@tinmarino tinmarino merged commit e006da5 into vimwiki:dev Jul 22, 2020
@tinmarino tinmarino mentioned this pull request Jul 22, 2020
Closed
@tinmarino tinmarino moved this from In progress to Done in v2.6 Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinmarino tinmarino tinmarino approved these changes

Assignees
No one assigned
Labels
HTML conversion test-needed Add a non-regression test
Projects
No open projects
v2.6
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eltrufas @tinmarino