Fix :VimwikiNextTask #959
Merged
Fix :VimwikiNextTask #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct function for accessing 'rxListItemWithoutCB'. `ac4d0a1d46` refactored access to vars and it appears this is one place where `get_syntaxlocal` should have been renamed to `get_wikilocal` but was accidentally skipped.
rylwin
force-pushed
the
fix-vimwiki-next-task
branch
from
498ac0b
to
a81056d
Compare
|
Hi @rylwin , nice catch, nice fix, nice tests. |
|
Please keep on with nice contribution like that: you can have a look at good first issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct function for accessing 'rxListItemWithoutCB'.
ac4d0a1d46refactored access to vars and it appears this is one placewhere
get_syntaxlocalshould have been renamed toget_wikilocalbutwas accidentally skipped.
Steps for submitting a pull request:
devbranch!doc/vimwiki.txtif applicable,including the Changelog and Contributors sections.
I've been running on
devto take advantage of some of the latest changes there and noticed thatgntno longer works for me. I think I tracked down the issue and added a test to confirm the bug and related fix. That said, this is my first time contributing to this project and using vader for tests. Happy to make any tweaks to get this PR cleaned up and ready to merge!