Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a logo and added it to the title. #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mgilberties
Copy link

Description

  • Made a logo in Illustrator.
  • Removed some invalid HTML.
  • Added the logo to the title section.
  • Updated the styles.

Related issue(s)

Resolves #21

- Made a logo in Illustrator.
- Removed some invalid HTML.
- Added the logo to the title section.
- Updated the styles.
Copy link
Owner

@vinayakgavariya vinayakgavariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mgilberties glad you want to contribute to it.
but I don't want to change the header of the website.
instead I want to change the logo which comes in the tab of the browser along with the website name.

@mgilberties
Copy link
Author

@VG-1 Ahhh sorry, it was the terminology that threw me off course. You are after a Favicon, not a logo. I will change my push to reflect this.

@vinayakgavariya
Copy link
Owner

hey @mgilberties my bad sorry
Can you just send a video or gif how does favicon looks like.
Also push your commit to latest changes of the repo to avoid merge conflicts.

@vinayakgavariya
Copy link
Owner

Hey @mgilberties are you working on it?

@mgilberties
Copy link
Author

@VG-1 feel free to unassign this and let someone else have a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design a cool logo for the website and add it to title.
2 participants