Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DI #32

Closed
wants to merge 1 commit into from
Closed

fix DI #32

wants to merge 1 commit into from

Conversation

ts-ign0re
Copy link

The problem is:

import ngMeta from 'ng-meta'; // error here - unused variable
const app = angular.module(APP_NAME, ['ngMeta']);

in this case we have an eslint error, but if we inject ngMeta as object we will have injection error (lost dependency name on minification)

@ts-ign0re
Copy link
Author

@vinaygopinath all tests is ok

@ts-ign0re ts-ign0re closed this Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants