-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ColorDrawable support #30
Comments
If you don't mind testing, please update your dependencies to use the snapshot and let me know how it performs:
|
Will try it out. I actually ended up implementing a RoundedColorDrawable that works very well that I had planned to PR |
doesn't work for me with custom drawable (it seems that wrong canvas size (1x1) is passed) |
what custom drawable are you passing in? |
nothing very special, just |
Ah, I would do one of 2 things:
|
first one is obviously not a solution, neither is the second one - I must call |
why must you call Otherwise if you're already doing all the custom drawing just do |
I don't have any bitmap part of avatar. |
This library is a convenience for people who don't want to write custom views and specifically optimizes for the case of rounded bitmaps. It's not meant to augment custom views/drawables well since the behavior most custom views is, well... very custom. It's impossible to predict how all custom views will work and accommodate for all of them. Like I said, if your view has extra behavior on top of being rounded, I suggest extending or forking this library to reuse the code, otherwise supporting arbitrary custom drawables and views is not the aim of this library. |
Snapshot build does round the corners for us on color drawables. Once it's officially released we'll switch to using it. Thanks! |
Cool, there are still some bugs I can't seem to hunt down (see example app), but if it works for most cases I'll push up the new version now. |
@vinc3m1 I fully agree on your points about limited features support and forking, the only problem is that you realize limitations only after the first run and spend useless efforts on adding library to your project. |
No description provided.
The text was updated successfully, but these errors were encountered: