Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags with dots in them break the parser #7

Closed
radix opened this issue Jul 20, 2017 · 2 comments
Closed

Tags with dots in them break the parser #7

radix opened this issue Jul 20, 2017 · 2 comments

Comments

@radix
Copy link

radix commented Jul 20, 2017

Hey @vincaslt ! I'm super stoked that you worked on a fix for #5 , but sadly I have to report that it seems to have introduced a different issue with JSX: now tags that have dots in them are breaking the parser. This happens when code imports a module and uses a qualified name to specify the tag:

import * as CV from './CommonView';

function foo() {
    return <CV.Whatever><span>Hi!</span></CV.Whatever>;
}

This is also breaking when any child has a tag that is prefixed by the parent tag, then followed by a dotted name after. I realize that's a confusing formulation, here's an example:

function foo() {
    return <X><X.Whatever /></X>;
}

In this example the <X> doesn't match with the </X>. I'm noticing this when using certain libraries like react.semantic-ui.com, which nests component classes, so you use stuff like:

function foo() {
    return <Form><Form.Button>Submit</Form.Button></Form>;
}

It think that neither of these behaviors happened before the latest release (i.e. the tags would match properly as long as there was no => confusing it), but I'm not 100% certain.

If you're not interested in supporting JSX I understand, I just thought I'd let you know!

@vincaslt
Copy link
Owner

Hmm, I didn't expect dots to be in the name, but that makes sense.

@vincaslt
Copy link
Owner

Thanks for reporting your findings! I think it should be working properly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants