Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to choose replay files to find highlights in #89

Open
jazzdan opened this issue Jul 3, 2020 · 1 comment · May be fixed by #103
Open

Ability to choose replay files to find highlights in #89

jazzdan opened this issue Jul 3, 2020 · 1 comment · May be fixed by #103

Comments

@jazzdan
Copy link

jazzdan commented Jul 3, 2020

Maybe I have a weird setup, but it seems useful to me to be able to select just some replay files to process rather than having to process the whole directory.

My setup is:

  1. Slippi is set to put replays in C:\Users\me\Documents\Slippi
  2. I never want to delete a replay because I'm totally going to look through all of these replays and take notes to get better. Even though uhh I haven't done that yet.

So when I run project clippi in C:\Users\me\Documents\Slippi it always runs over all of my replays, which takes a while, and I end up with a bunch of combos I have already seen so the "Load output file into Dolphin when complete" option isn't very useful.

It would be better for me if I could manually select which replay files to process or if I could specify a time range like "only look at files modified in the last week".

Thanks for the great project! If this sounds amenable to folks I can try to put a PR together too.
@vinceau
Copy link
Owner

vinceau commented Jul 4, 2020 •
edited
Loading

I think to achieve what you're proposing it's not too hard for someone to simply create a new temp folder say .../Documents/Slippi/tmp and just put some SLP files in there, and change the SLP directory to that folder. I know it's not very clean, but I think it's simple and it works.

Allowing users to manually add files or select time frames etc would be cool and would help power users, I think it could overly complicate the process for not-so-savvy users. But if you think you can add the functionality while keeping the UI/UX clean and without overbearing new users I'd definitely be happy to review a PR for it.

@vinceau vinceau added enhancement New feature or request and removed enhancement New feature or request labels Jul 4, 2020
jazzdan added a commit to jazzdan/project-clippi that referenced this issue Aug 21, 2020
@jazzdan
Add option to process entire replay directory or just selected files
f6fed39 
Fixes vinceau#89
@jazzdan jazzdan linked a pull request Aug 21, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to process entire replay directory or just selected files jazzdan/project-clippi
2 participants
@jazzdan @vinceau