Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to process entire replay directory or just selected files #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jazzdan
Copy link

@jazzdan jazzdan commented Aug 21, 2020

Relevant part of the replay processor now looks like this:

image

If you select the "Select by individual files" radio button it changes to:

image

Note that "Include subfolders" and "Open location" buttons get greyed out when you do this.

I'm open to other UIs, this is not my forte.

Going in to this change I was surprised to learn that neither Windows nor macOS let you open a file picker that allows you to select both directories and files, but Linux does. That made this slightly less elegant to implement than I had hoped. I would have liked the FileInput component to be able to select one directory, one file, or multiple files but I couldn't get this to work with TypeScript in a sound way and it seemed to be fighting the way the OS APIs want things to work anyways.

Happy to make any changes necessary, and if you decide this isn't a change you want to include no worries. :)

Thanks for building and maintaining this!

Fixes #89

@vinceau
Copy link
Owner

vinceau commented Aug 22, 2020

Thanks for working on this PR! I think the functionality itself seems mostly fine but like you mentioned, since the Electron API for Mac and Windows doesn't allow choosing both files and folders I feel having those radio options overly complicates the user experience. Turning enabled buttons to disabled but still visible also doesn't help in that regard either. I'm going to leave this PR unmerged until we can achieve a better UI/UX.

@jazzdan
Copy link
Author

jazzdan commented Aug 24, 2020

Yeah that's totally fair, I'll stew on it for a bit and see if I can come up with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to choose replay files to find highlights in
2 participants