Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh script ignores "dest" parameter #38

Closed
simonbcn opened this issue Sep 26, 2018 · 1 comment

Comments

@simonbcn
Copy link

@simonbcn simonbcn commented Sep 26, 2018

...
install() {
  local dest=${1}
  local name=${2}
  local color=${3}
  local size=${4}
  local radius=${5}

  [[ ${color} == '-dark' ]] && local ELSE_DARK=${color}
  [[ ${color} == '-light' ]] && local ELSE_LIGHT=${color}

  local THEME_DIR=${DEST_DIR}/${name}${color}${size}${radius}

  [[ -d ${THEME_DIR} ]] && rm -rf ${THEME_DIR}

  echo "Installing '${THEME_DIR}'..."

  mkdir -p                                                                           ${THEME_DIR}
....

The $1 parameter is assigned to dest variable but that variable isn't used. Instead DEST_DIR is used.
It should be:

...
install() {
  local DEST_DIR=${1}
....
@vinceliuice

This comment has been minimized.

Copy link
Owner

@vinceliuice vinceliuice commented Sep 26, 2018

Thanks! I'll fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.