Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check tools part2 #23

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Conversation

n-peugnet
Copy link
Contributor

@n-peugnet n-peugnet commented Jan 8, 2021

  • add parallel lint to check for syntax errors
  • add phpcs PSR12
  • add phpstan doctrine extension (to check DQL and some doctrine magic)

To fix most of PHPCS errors you can run the following command:

composer fix

All of the commands I added are composer scripts that you can check in composer.json:

antilope/composer.json

Lines 98 to 116 in f20b95f

"check": [
"@phpcs",
"@phpstan",
"@check-symfony"
],
"check-symfony": [
"@php bin/console --ansi lint:container",
"@php bin/console --ansi lint:twig",
"@php bin/console --ansi doctrine:schema:validate --skip-sync"
],
"fix": [
"@phpcbf"
],
"phpcs": "phpcs --runtime-set ignore_warnings_on_exit 1",
"phpcbf": "phpcbf",
"phpstan": [
"@php bin/console cache:warmup -q",
"phpstan analyse --ansi"
],

Part of #17

@n-peugnet n-peugnet force-pushed the check-tools-2 branch 2 times, most recently from e363461 to f20b95f Compare January 8, 2021 20:44
@vincent-peugnet vincent-peugnet merged commit 80f289e into vincent-peugnet:main Jan 14, 2021
@n-peugnet n-peugnet mentioned this pull request Jan 15, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants