receiver: fix logging with Android

The use of apply is dangerous if we accidently pass additional arguments to the log function.. This made Dashkiosk reload on some errors.
vincentbernat · Nov 5, 2016 · 2d8807d · 2d8807d
1 parent 9a57f12
commit 2d8807d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/app/scripts/receiver/console.js b/app/scripts/receiver/console.js
@@ -2,9 +2,9 @@ module.exports = (function(window) {
   'use strict';
 
   if (window.JSInterface && window.JSInterface.log) {
-    var log = function() {
-      return function() {
-        window.JSInterface.log.apply(window.JSInterface, arguments);
+    var log = function(level) {
+      return function(message) {
+        window.JSInterface.log(level + ': ' + message);
       };
     };
     return {

diff --git a/app/scripts/receiver/iframe-queue.js b/app/scripts/receiver/iframe-queue.js
@@ -100,8 +100,8 @@ module.exports = (function(window, undefined) {
       ready: function() {
         // Sanity check: are we the first iframe?
         if (iframe !== this.queue[0]) {
-          console.warn('[Dashkiosk] BUG: request to display a new iframe which is not in our queue',
-                       iframe, this.queue);
+          console.warn('[Dashkiosk] BUG: request to display a new iframe which is not in our queue (' +
+                       iframe + ', ' + this.queue);
           iframe.remove();
           return;
         }