socketio: don't crash if we didn't get an IP address for client

Related to #40.
vincentbernat · Feb 9, 2016 · ca98006 · ca98006
1 parent 5063a49
commit ca98006
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/api/socketio/displays.js b/lib/api/socketio/displays.js
@@ -14,7 +14,10 @@ function handleNewDisplay(io) {
   io.on('connection', function(socket) {
     var ip = (socket.handshake.headers || {})['x-forwarded-for'] ||
           socket.request.connection.remoteAddress;
-    ip = ip.replace(/^:ffff:/, '');
+    if (ip) {
+      // For some reason, socket.io may not provide an IP in all cases
+      ip = ip.replace(/^:ffff:/, '');
+    }
     logger.info('new display', ip);
     socket.on('register', function(data, fn) {