Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create dag for stepfunctions workflow (Sourcery refactored) #76

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jun 20, 2021

Pull Request #75 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the 69-directed-graph branch, then run:

git fetch origin sourcery/69-directed-graph
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from vincentclaes June 20, 2021 19:03
@sourcery-ai sourcery-ai bot force-pushed the sourcery/69-directed-graph branch 4 times, most recently from cb8377b to bf93675 Compare June 20, 2021 19:20
@sourcery-ai sourcery-ai bot force-pushed the sourcery/69-directed-graph branch from bf93675 to d730d36 Compare June 21, 2021 06:52
task = StepfunctionsWorkflow._create_glue_start_job_run_step(job_name=job_name)
return task
return StepfunctionsWorkflow._create_glue_start_job_run_step(job_name=job_name)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function StepfunctionsWorkflow.add_task refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jun 21, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 1.83 ⭐ 1.85 ⭐ 0.02 👎
Method Length 39.82 ⭐ 39.65 ⭐ -0.17 👍
Working memory 6.32 🙂 6.30 🙂 -0.02 👍
Quality 82.59% 82.60% 0.01% 👍
Other metrics Before After Change
Lines 248 247 -1
Changed files Quality Before Quality After Quality Change
datajob/stepfunctions/stepfunctions_workflow.py 82.59% ⭐ 82.60% ⭐ 0.01% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
datajob/stepfunctions/stepfunctions_workflow.py StepfunctionsWorkflow._construct_toposorted_chain_of_tasks 10 🙂 104 🙂 10 😞 58.75% 🙂 Extract out complex expressions
datajob/stepfunctions/stepfunctions_workflow.py StepfunctionsWorkflow._integrate_notification_in_workflow 1 ⭐ 95 🙂 10 😞 68.70% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@vincentclaes vincentclaes merged commit 336adec into 69-directed-graph Jun 21, 2021
@vincentclaes vincentclaes deleted the sourcery/69-directed-graph branch June 21, 2021 07:00
@vincentclaes vincentclaes linked an issue Jun 22, 2021 that may be closed by this pull request
@vincentclaes vincentclaes added this to the 0.8.0 milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run sub pipelines in parallel
1 participant