Early check of header size if ELF64 is detected #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By feeding `Elf::from_bytes()` the first 52 bytes of a ELF64 header, it is possible to have the function read past the buffer given as parameter because the `ehsize` field is at a greater offset. The bug has been found using `cargo fuzz`.
samueltardieu
force-pushed
the
early-elf64-size-check
branch
from
19c02f9
to
537bb61
Compare
vincenthouyi
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By feeding
Elf::from_bytes()the first 52 bytes of a ELF64 header, it is possible to have the function read past the buffer given as parameter because theehsizefield is at a greater offset.The bug has been found using
cargo fuzzand can be demonstrated using the following base64 input toElf::from_bytes()oncedecoded: