Fix implicit certificate version. #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X.509 certificates without an explicit version are v1 certificates, but v1 is actually stored as 0 (just as v3 is 2). The Data.X509 API report the raw stored certificate versions, not the marketing name. Therefore, the implicit version is 0, not 1.
vdukhovni
force-pushed
the
fix-implicit-version
branch
from
60a85e8
to
a6eca06
Compare
|
thanks @vdukhovni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X.509 certificates without an explicit version are v1 certificates,
but v1 is actually stored as 0 (just as v3 is 2). The Data.X509 API
report the raw stored certificate versions, not the marketing name.
Therefore, the implicit version is 0, not 1.