Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance report for reference #24

Open
miloyip opened this issue Sep 9, 2016 · 1 comment
Open

Conformance report for reference #24

miloyip opened this issue Sep 9, 2016 · 1 comment

Comments

@miloyip
Copy link

miloyip commented Sep 9, 2016

https://github.com/miloyip/nativejson-benchmark/blob/master/sample/conformance_Vinenthz_libjson%20(C).md

@vincenthz
Copy link
Owner

Hey @miloyip, this is cool stuff, but you're not using the parser correctly.

  • The first issue is linked to not calling json_is_parser_done(); this will returns the proper error
  • The second issue is linked that you're expecting a double where this is clearly an integer.
  • The last issue, I'm not sure what this roundtrip is doing and which is which, it's hard to comment further.

miloyip added a commit to miloyip/nativejson-benchmark that referenced this issue Sep 10, 2016
miloyip added a commit to miloyip/nativejson-benchmark that referenced this issue Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants