Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Bug: Delimiter guessing overwrites column names." #46

Merged
merged 4 commits into from
Aug 18, 2019

Conversation

vincentlaucsb
Copy link
Owner

Fix issue #44

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #46 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   98.48%   98.64%   +0.15%     
==========================================
  Files          12       12              
  Lines         661      663       +2     
==========================================
+ Hits          651      654       +3     
+ Misses         10        9       -1
Impacted Files Coverage Δ
include/internal/csv_reader.hpp 100% <ø> (ø) ⬆️
include/internal/csv_format.hpp 83.33% <ø> (ø) ⬆️
include/internal/csv_reader.cpp 99.6% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1bcee...97c61b6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #46 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   98.48%   98.64%   +0.15%     
==========================================
  Files          12       12              
  Lines         661      663       +2     
==========================================
+ Hits          651      654       +3     
+ Misses         10        9       -1
Impacted Files Coverage Δ
include/internal/csv_reader.hpp 100% <ø> (ø) ⬆️
include/internal/csv_format.hpp 83.33% <ø> (ø) ⬆️
include/internal/csv_reader.cpp 99.6% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1bcee...97c61b6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant