Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect gpx extensions tagging when parent tag exists #65

Merged
merged 1 commit into from Nov 14, 2019
Merged

Fix incorrect gpx extensions tagging when parent tag exists #65

merged 1 commit into from Nov 14, 2019

Conversation

vincentneo
Copy link
Owner

Fixes #64

  • Removes unsupported methods

@vincentneo vincentneo mentioned this pull request Nov 14, 2019
Closed
@andrijamilovanovic
Copy link

andrijamilovanovic commented Nov 14, 2019 •
edited

Looks like fix is working.
I got proper XML for track extension:

			<extensions>
					<gpxtpx:TrackPointExtension>
						<gpxtpx:hr>57</gpxtpx:hr>
					</gpxtpx:TrackPointExtension>
			</extensions>

Thanks for quickly addressing reported defect.
Regards,
Andrija

@vincentneo
Copy link
Owner Author

@andrijamilovanovic
Glad that it worked! Will merge now!

Thanks for the verification!

@vincentneo vincentneo merged commit 97c6bd9 into master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writing to GPXExtension
2 participants
@vincentneo @andrijamilovanovic