splice: signer must be informed of splice params #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devrandom
reviewed
Oct 4, 2023
vincenzopalazzo
force-pushed
the
macros/remote-signer-with-splicing
branch
2 times, most recently
from
63b0590
to
defead9
Compare
devrandom
reviewed
Oct 4, 2023
| /* We calculcate the `push_value` to send to the | ||
| * hsmd, that is the remote amount in the channel | ||
| * after the splice. */ | ||
| switch (our_role) { |
There was a problem hiding this comment.
this is hard to analyze, because our_role is used to calculate opener, but then both opener and our_role are used in the logic below. it would be best to use only one or the other.
There was a problem hiding this comment.
Ok this should be solved in the last version of the commit, let me know if this help
devrandom
reviewed
Oct 4, 2023
vincenzopalazzo
force-pushed
the
macros/remote-signer-with-splicing
branch
from
defead9
to
c3b56e7
Compare
devrandom
reviewed
Oct 4, 2023
The signer needs to know when the splice operation starts and the splice parameters for each splice transaction candidate. The channel establishment v2 (dual funding) code path already notifies the signer via the hsmd API hsmd_ready_channel calls However, the splicing code path does not. Link: ElementsProject#6723 Suggested-by: @devrandom Co-Developed-by: @devrandom Co-Developed-by: Ken Sedgwick <ken@bonsai.com> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/remote-signer-with-splicing
branch
from
c3b56e7
to
cf18fa6
Compare
|
Moving this upstream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review before opening a draft PR to cln