Spaces in sheets names

[lfaucheux]

Nice package!

One really simple question. What about space-contained sheets names ? I mean

>>> import formulas
>>> formulas.Parser().ast("=SUM(sheetname!A3)")[1].compile().inputs
OrderedDict([('SHEETNAME!A3', <Ranges>(SHEETNAME!A3))])

works fine. But,

>>> problematic = "'sheet name'!A3"
>>> formulas.Parser().ast(f"=SUM({problematic})")[1].compile().inputs
OrderedDict([('SHEET NAME!A3', None)])
                               ^^^^

doesn't. What's strange is that

>>> formulas.Ranges().push(problematic)
<Ranges>(SHEET NAME!A3)

does the job for what I can tell.

[lfaucheux]

Another dirty hack: at line 199 of tokens/operand.py, redefining _build_id as follows

def _build_id(ref, sheet='', excel=''):
    if excel or sheet:
        sheet = sheet.replace("''", "'")
    if excel:
        sheet = "[%s]%s" % (excel, sheet)
        if not fxl.tokens.operand._re_build_id.match(excel):
            sheet = "'%s'" % sheet
    elif sheet and ' ' in sheet:
        sheet = "'%s'" % sheet
    return '!'.join(s for s in (sheet, ref) if s)

Until you fix that, I will patch as shown above, which may not be the best option since I miss the global picture. Anyway, a big thank you for formulas.

[vinci1it2000]

Thanks for your finding! The correction is close to your proposal.