Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying Model Outputs #65

Closed
cc-a opened this issue Jan 18, 2021 · 5 comments
Closed

Specifying Model Outputs #65

cc-a opened this issue Jan 18, 2021 · 5 comments
Assignees

Comments

@cc-a
Copy link

cc-a commented Jan 18, 2021

Is your feature request related to a problem? Please describe.

We have encountered performance issues when attempting to use Formulas with complex spreadsheets ~14MB in size. Finishing time was at several days and still not completed.

Describe the solution you'd like

The ability to limit construction of the execution graph based on specified output cells/named ranges. From use of other libraries (e.g. excel_to_code) we've found this to be a key approach to reduce parsing times.

Describe alternatives you've considered

A considerable amount of work to manually prune unnecessary parts of the spreadsheet but this is not a flexible or scalable approach.

Additional context

I'm enquiring on behalf of a research group at Imperial College London. We are interested in this functionality to explore the use of Formulas in an on-going project. We may be able to implement this functionality (our guess is that it should be fairly simple) if you can recommend an approach and point us to where to get started.

@cc-a
Copy link
Author

cc-a commented Feb 15, 2021

Hiya. Any thoughts on this? We're hoping to be able to start work on this soon so any guidance you're able to provide would be much appreciated.

@vinci1it2000
Copy link
Owner

Sorry I did a typo in the commit message. Anyhow, you can try my dev, I did some changes to improve the reading performances. I added a method load_from_range to the ExcelModel. An example of usage is documented in the readme.

@cc-a
Copy link
Author

cc-a commented Feb 15, 2021

Wow, thank you for this! I will take a look how this performs with our models.

@vinci1it2000 vinci1it2000 self-assigned this Feb 16, 2021
@vinci1it2000 vinci1it2000 added this to the Filicudi release milestone Feb 16, 2021
@cc-a
Copy link
Author

cc-a commented Mar 1, 2021

Thanks very much for this, just picking it up now. Hitting an immediate issue with this functionality and named ranges. I infer from ranges.py that these are not just not supported. Any suggestions on how to proceed?

@vinci1it2000
Copy link
Owner

The named ranges are supported by the library. The highlighted lines are used when the named range is not resolved, i.e. when it is missing the referenced file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants