(tool) Fix images not being output to dist on gulp build #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaromero
added a commit
that referenced
this pull request
Jul 29, 2015
(tool) Fix images not being output to dist on gulp build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related task
Imágenes de posts no se están viendo (97841)
Problem
gulp buildis placing the images intodist/imagescorrectly, but jekyll deletes them afterwards. This causes the final build to lack the directory, and therefore no local images can be used (images from external posts are still fine)Solution
The tasks are rearranged to ensure that jekyll runs before the image optimization step, which then places the images where they belong
Tests
Tested by running
gulp buildto verify that the images task runs after the jekyll task, and that theimagesdir is present and contains the actual images.