Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer isn't stopped when a player joins #11

Closed
canthisbe opened this issue Apr 11, 2023 · 3 comments
Closed

Timer isn't stopped when a player joins #11

canthisbe opened this issue Apr 11, 2023 · 3 comments

Comments

@canthisbe
Copy link

Title. For example, last player leaves, starting the hour timer. Someone could join right after but the timer would still be running. That player leaves right before the timer is done, then voila, the server is shutdown despite it being inactive for way less than an hour. Having it so the timer is cancelled when someone joins would be better than checking for a player once the timer is done.

@vincss
Copy link
Owner

vincss commented Apr 12, 2023

Yes, I already notice that but didn't happen that much, so I kept it that way.
Maybe I will try to cancel the timer when someone connect.

@vincss
Copy link
Owner

vincss commented Apr 13, 2023

Hi,
I made a new release, you can give it a try :
https://github.com/vincss/mcEmptyServerStopper/releases/tag/v1.1.0

@canthisbe
Copy link
Author

Hey, sorry for late response! I've used it and it has worked flawlessly, thank you! Forgot to mention this, but in the previous release, when it detected empty again, it would just create another timer instead of resetting the previous, so multiple timers would run and each timer would check on their respective end. The new release also fixed that issue inherently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants