Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.lisp and asd file. #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jgarte
Copy link

@jgarte jgarte commented Mar 14, 2023

Hi,

This closes #1

See the questions I left in #1 which would still need to be added to this PR.

package.lisp Outdated
@@ -0,0 +1,3 @@
(defpackage getpid
(:use #:cl)
(:export #:save-pid))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to export getpid too :)

(re naming: "getpid" without a "-" and "save-pid" with one, is it ok?

Copy link
Author

@jgarte jgarte Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a new commit exporting getpid also. I must have missed that one ;()

(re naming: "getpid" without a "-" and "save-pid" with one, is it ok?

getpid currently has a -. Do you mean that you'd like to rename it to get-pid?

Not sure I fully understand... Can you clarify the above point further?

Copy link
Author

@jgarte jgarte Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of renaming getpid to get-pid or get-process-id or get-process-identifier?

Username dlowe on common-lisp:matrix.org had suggested this because of tension between a POSIX name and a more lispy version of the name.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit lame, because in all implementations it's named getpid… but +1 to rename to get-pid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: asd file
2 participants