Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework should only contain Redacted API Keys, and not the functionality #161

Closed
kunalverma25 opened this issue Mar 28, 2019 · 4 comments
Assignees

Comments

@kunalverma25
Copy link

The MailGun, TinyURL etc functionality is also inside the framework, So developers cannot extend and/or change that functionality. Which kinda diminishes the whole purpose of open-sourcing. Personally I think, only the keys should be redacted and not the functionality, so if some dev wants to extend the functionality, they can do so easily.

@vineetchoudhary
Copy link
Member

vineetchoudhary commented Mar 28, 2019

Hi, that doesn't make any sense because anyone can access those keys and misuse them.

I only added very limited functionality in the private framework. Before this, all these things were open source but some user doesn't want to create the key for mailgun and branch.io app to run the AppBox from source code. So, that's why created that private framework.

I'm thinking a different way, I'll open source that private framework without any key. Where user can rebuild that framework with their own key.

@vineetchoudhary vineetchoudhary self-assigned this Mar 28, 2019
@kunalverma25
Copy link
Author

Yeah.. Maybe a different branch, without the keys?

@kunalverma25
Copy link
Author

kunalverma25 commented Mar 28, 2019

@vineetchoudhary Any estimated when, you'll be able to add this?
Basically a way to add own keys/config for Dropbox, MailGun, Tiny etc..
Btw.. Thanks for such an awesome project!

@vineetchoudhary
Copy link
Member

Hi, I can't promise. But I'll surely work on it. I already have a few things to plan for this.

After these, I'll work on this.

@vineetchoudhary vineetchoudhary closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants