Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fields property optional on SimpleMessagesProvider #18

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Make fields property optional on SimpleMessagesProvider #18

merged 1 commit into from
Oct 16, 2023

Conversation

TiBianMod
Copy link
Contributor

this PR makes the fields property optional on SimpleMessagesProvider

on docs, I see that the fields property is not required on SimpleMessagesProvider

Now if you want to use SimpleMessagesProvider you need to pass a second argument

new SimpleMessagesProvider({
  'required': 'The {{ field }} field is required',
}, {})

@TiBianMod
Copy link
Contributor Author

cc, @thetutlage @RomainLanz

@thetutlage thetutlage merged commit 16bd6e8 into vinejs:develop Oct 16, 2023
2 of 6 checks passed
@thetutlage
Copy link
Contributor

Thanks 👍

@thetutlage thetutlage self-requested a review October 16, 2023 04:42
@thetutlage thetutlage added Type: Enhancement Improving an existing feature Semver: Patch A bug fix labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Semver: Patch A bug fix Type: Enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants