Skip to content

Commit

Permalink
Remove duplicate settings and throw when there is one
Browse files Browse the repository at this point in the history
  • Loading branch information
vingtetun committed Jul 6, 2012
1 parent f0e3bba commit 94cdcde
Showing 1 changed file with 20 additions and 16 deletions.
36 changes: 20 additions & 16 deletions build/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ var settings = [
new Setting("sms.ring.received", true),
new Setting("sms.vibration.received", true),
new Setting("ums.enabled", false),
new Setting("ums.mode", ""),
new Setting("ril.data.roaming.enabled", false),
new Setting("ril.data.apn", ""),
new Setting("ril.data.user", ""),
Expand All @@ -54,36 +55,39 @@ var settings = [
new Setting("ril.data.mmsport", 0),
new Setting("devtools.debugger.remote-enabled", false),
new Setting("devtools.debugger.log", false),
new Setting("devtools.remote.port", 6000),
new Setting("devtools.remote.force-local", true),
new Setting("debug.fps.enabled", false),
new Setting("devtools.debugger.remote-port", 6000),
new Setting("devtools.debugger.force-local", true),
new Setting("debug.debug.paint-flashing.enabled", false),
new Setting("homescreen.wallpaper", "default.png"),
new Setting("ums.enabled", false),
new Setting("debug.grid.enabled", false),
new Setting("accessibility.invert", false),
new Setting("lockscreen.enabled", true),
new Setting("lockscreen.wallpaper", "default.png"),
new Setting("lockscreen.passcode-lock.enabled", true),
new Setting("ril.radio.disabled", false),
new Setting("ril.data.enabled", false),
new Setting("ums.mode", ""),
new Setting("keyboard.vibration", false),
new Setting("keyboard.clicksound", ""),
new Setting("keyboard.layout.english", true),
new Setting("keyboard.layout.dvorak", false),
new Setting("keyboard.layout.spanish", false),
new Setting("keyboard.layout.portuguese", false),
new Setting("keyboard.layout.otherlatins", false),
new Setting("keyboard.layout.cyrillic", false),
new Setting("keyboard.layout.hebrew", false),
new Setting("keyboard.layout.zhuyin", false),
new Setting("keyboard.layout.pinyin", false),
new Setting("keyboard.layout.arabic", false),
new Setting("keyboard.layout.greek", false),
new Setting("keyboard.layout.japanese", false)
new Setting("keyboard.layouts.japanese", false),
new Setting("keyboard.layouts.portuguese", false),
new Setting("keyboard.layouts.spanish", false),
new Setting("screen.timeout", 60)
];

// Ensure there is no duplicate
for (let i in settings) {
var settingName = settings[i].name;
for (let j in settings) {
if (i === j)
continue;

if (settingName === settings[j].name) {
throw new Error('There is a at least 2 settings called: ' + settingName);
}
}
}

function Setting(aName, aValue) {
this.name = aName;
this.value = aValue;
Expand Down

0 comments on commit 94cdcde

Please sign in to comment.