Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: websocket scope error #43

Closed
yanyongyu opened this issue Dec 22, 2021 · 1 comment
Closed

Bug: websocket scope error #43

yanyongyu opened this issue Dec 22, 2021 · 1 comment

Comments

@yanyongyu
Copy link
Contributor

yanyongyu commented Dec 22, 2021

According to asgi document, the websocket connection scheme should be ws or wss, but get http

This cause test failure for quart 0.15+/0.16+ (Error BadRequest)

scope = {
"type": "websocket",
"headers": flatten_headers(headers),
"path": path,
"query_string": query_string_bytes,
"root_path": "",
"scheme": "http",
"subprotocols": [],
}

Reference: https://asgi.readthedocs.io/en/latest/specs/www.html#websocket-connection-scope

@masipcat
Copy link
Contributor

Fix released in v1.4.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants