Refactor code in background.js

[vinitshahdeo]

• Please check background.js and refactor the different methods inside this.

• Do small, incremental changes that leave the code in a better state than it was found.

• Do not make any changes in other files.

• Make sure that the existing functionality shouldn't break.

[aleoof]

i will do this

[JordanRosas]

Is anyone assigned to this issue? I would like to participate if possible!

[vinitshahdeo]

@aleoof Yes, please go ahead.

[vinitshahdeo]

@JordanRosas No actually, give it a shot, I'll merge the most optimized code.

[JordanRosas]

Hi @vinitshahdeo last night I ran your project fresh and and when I opened my devtools I got three errors

• A bad HTTP response code (404) was received when fetching the script.
• background.js:174 Uncaught TypeError: Cannot read property 'get' of undefined
  at setCookieCount (background.js:174)
  at background.js:180 (Don't mind the line numbers I had my refactored code sitting on top of the old code for reference)
• GET http://127.0.0.1:8080/index.js net::ERR_ABORTED 404 (Not Found)

is there something I am missing on my end?

[vinitshahdeo]

@JordanRosas It seems you opened index.html in chrome directly. It's a chrome extension so it's supposed to be installed locally. Please refer this.

[JordanRosas]

Hi Again! Pardon my many questions I've never worked with a chrome extension. I tried to load the unpacked extensions from the instructions in hour README and I get a Filed to load extension with the following message => Cannot load extension with file or directory name _config.yml. Filenames starting with "_" are reserved for use by the system. Could not load manifest. Any Ideas?

…

On Fri, Oct 11, 2019 at 8:01 AM Vinit Shahdeo ***@***.***> wrote: @JordanRosas <https://github.com/JordanRosas> It seems you opened index.html in chrome directly. It's a chrome extension so it's supposed to be installed locally. Please refer this <https://developer.chrome.com/extensions/getstarted>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AH3LLVR3ZBTF7UOXTL4VZELQOB2JTA5CNFSM4I7R5RIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA75P4A#issuecomment-541054960>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3LLVVE2QWLBCPSQAG3ZK3QOB2JTANCNFSM4I7R5RIA> .

[vinitshahdeo]

@JordanRosas My bad. Please delete that file (_config.yml). It's not supposed to be there. This for GitHub pages.

[JordanRosas]

Awesome thanks.

…

On Fri, Oct 11, 2019 at 9:05 AM Vinit Shahdeo ***@***.***> wrote: @JordanRosas <https://github.com/JordanRosas> My bad. Please delete that file (_config.yml). It's not supposed to be there. This for GitHub pages. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AH3LLVTZA4TOUY5VZKF7EKLQOCB3VA5CNFSM4I7R5RIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBADKMY#issuecomment-541078835>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3LLVWUOOPXTOKAVOA2ABTQOCB3VANCNFSM4I7R5RIA> .

[vinitshahdeo]

@JordanRosas You're welcome!

[JordanRosas]

@vinitshahdeo I have a PR up for some reason I couldnt add you as a reviewer?

[vinitshahdeo]

@JordanRosas No problem. Thank you for the PR. I'll review and merge it soon.

You may look into a few more good first issues here which are up for grabs!