The low & high range of ports in scanner.py is hardcoded

[vinitshahdeo]

Reading config.json and using range.low and range.high in scanner.py

---

The range for ports shouldn't be hardcoded. It should be ideally fetched from config.json as it's being used in server/index.js.

for port in range(1,8888):  
        sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
        result = sock.connect_ex((remoteServerIP, port))
        if result == 0:
            print "Port {}: 	 Open".format(port)
        sock.close()

[TaniaMalhotra]

Hii
I have opened a PR for the same

[vinitshahdeo]

Thanks @TaniaMalhotra, will have a look into this. 👍

[tinovasq]

Hello! I noticed that someone already solved this issue, but I wanted to go ahead and throw in my own since I didn't see the PR until I was finished with it. I also updated the necessary syntax to work in py3.8

[vinitshahdeo]

@tinovasq That's great. 👏 Will have look into this.

[vinitshahdeo]

@TaniaMalhotra Check Water Monitoring System. See if you can find something interesting there.

[subhangi2731]

can you please assign it to me?