Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Inspirational Quotes #4

Open
vinitshahdeo opened this issue Oct 1, 2019 · 24 comments · May be fixed by #245

Comments

@vinitshahdeo
Copy link
Owner

commented Oct 1, 2019

You see, the way you think and feel about yourself, including your beliefs and expectations about what is possible for you, determines everything that happens to you.

Do you know any inspirational quotes so one can start working by taking control over thoughts, thinking positively and setting new goals?

Append your quote to data.json inside the data/ folder and raise the PR.

   {  
      "text":"Your new Quote",
      "from":"Author of your quote"
   }

Let's get everyone inspired by your contribution to the list of Inspirational Quotes.

Note:

  • Please avoid the repetition of quotes.
  • Do not make any changes in other files
  • Provide a source of truth (i.e. relevant link) in PR description for the quote you've added.
  • PR should contain a single quote. If you wish to add many quotes, create multiple PRs.
  • Add me(@vinitshahdeo) as reviewer.

PS - You may find a few more issues here!

Open Source Love

Thanks!

@abraaoduarte

This comment has been minimized.

Copy link

commented Oct 1, 2019

Add Henry Ford's quote #20

flamespt added a commit to flamespt/inspirational-quotes that referenced this issue Oct 2, 2019
@jsrneha

This comment has been minimized.

Copy link

commented Oct 3, 2019

Added Ratan Tata quotes #83

@akashbhandwalkar

This comment has been minimized.

Copy link

commented Oct 3, 2019

I have added the Quote. #93

@luizpericolo

This comment has been minimized.

Copy link

commented Oct 9, 2019

@vinitshahdeo Do you need help validating the PRs? Or are you waiting for the issue regarding the test to be resolved in order to merge the PRs?
If you need help I can work through some of the PRs validating that the quotes are not already in the file and that the proof is present.

@vinitshahdeo

This comment has been minimized.

Copy link
Owner Author

commented Oct 9, 2019

@luizpericolo Hey, I'm waiting for the unit-test for the same. The automated workflow is always good.

@saltgen

This comment has been minimized.

Copy link

commented Oct 11, 2019

Added a quote from Batman Begins

#296

Requesting your review, @vinitshahdeo, thank you. For some reason I wasn't able to add you as reviewer.

@vinitshahdeo

This comment has been minimized.

Copy link
Owner Author

commented Oct 11, 2019

@saltgen No problem, I will review and merge it soon.

@deadSnowman

This comment has been minimized.

Copy link

commented Oct 11, 2019

requesting review as well @vinitshahdeo

@vinitshahdeo

This comment has been minimized.

Copy link
Owner Author

commented Oct 11, 2019

@deadSnowman Will review it soon. You may look into a few more issues that are up for grabs.

@GeniusStorm

This comment has been minimized.

Copy link

commented Oct 11, 2019

@vinitshahdeo Can you please review and merge the incoming PRs

@vinitshahdeo

This comment has been minimized.

Copy link
Owner Author

commented Oct 11, 2019

@GeniusStorm I'll be merging it soon. Just waiting for the unit-tests. Give me one week. I'll be merging next week.

@Kudzanayi-Dzvairo

This comment has been minimized.

Copy link

commented Oct 14, 2019

Added Muhammed Ali quote #379

@somijaiswal23

This comment has been minimized.

Copy link

commented Oct 14, 2019

#393 Added quotes. Please have a review.

@vinitshahdeo

This comment has been minimized.

Copy link
Owner Author

commented Oct 15, 2019

@somijaiswal23 Thanks for the PR. I'll review it soon.
You may look into a few good first issues which are up for grabs.

Link to the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
HacktoberFest 2019
  
For Beginners
You can’t perform that action at this time.