Remove error::success (API Change)

fix cppalliance#55

CHANGELOG.md

@@ -1,6 +1,7 @@
 1.0.2
 
 * Better CMakeLists.txt for finding Boost
+* Remove error::success (API Change)
 
 ---
 

include/nudb/detail/format.hpp

@@ -398,7 +398,8 @@ write(File& f, key_file_header const& kh, error_code& ec)
         ec = error::invalid_block_size;
         return;
     }
-    std::fill(buf.get(), buf.get() + buf.size(), 0);
+    std::fill(buf.get(), buf.get() + buf.size(),
+        (unsigned char)0);
     ostream os{buf.get(), buf.size()};
     write(os, kh);
     f.write(0, buf.get(), buf.size(), ec);

include/nudb/error.hpp

@@ -81,12 +81,6 @@ namespace errc = boost::system::errc;
 /// Database error codes.
 enum class error
 {
-    /** No error.
-
-        The operation completed successfully.
-    */
-    success = 0,
-
     /** The specified key was not found.
 
         Returned when @ref basic_store::fetch does not

include/nudb/impl/error.ipp

@@ -27,9 +27,7 @@ nudb_category()
         {
             switch(static_cast<error>(ev))
             {
-            case error::success:
-                return "the operation completed successfully";
-
+            default:
             case error::key_not_found:
                 return "key not found";
 
@@ -146,9 +144,6 @@ nudb_category()
 
             case error::duplicate_value:
                 return "duplicate value";
-
-            default:
-                return "nudb error";
             }
         }
 

test/error.cpp

@@ -33,7 +33,6 @@ class error_test : public beast::unit_test::suite
     {
         nudb_category().message(0);
         nudb_category().message(99999);
-        check("nudb", error::success);
         check("nudb", error::key_not_found);
         check("nudb", error::key_exists);
         check("nudb", error::short_read);