Skip to content

Commit

Permalink
Bug 1855763 - Disable -moz-transform and enable zoom on Nightly. r=zc…
Browse files Browse the repository at this point in the history
…orpan

Disable zoom on a couple tests that otherwise fail. They're known
issues:

 * offsetWidth/Height not being unzoomed (button-min-width).
 * getComputedStyle not being unzoomed (font-size-interpolation-003.html)
 * ResizeObserver box not being unzoomed (w3c/csswg-drafts#9398).

Differential Revision: https://phabricator.services.mozilla.com/D189644
  • Loading branch information
emilio committed Oct 19, 2023
1 parent 2c498bf commit b863d00
Show file tree
Hide file tree
Showing 11 changed files with 21 additions and 18 deletions.
14 changes: 8 additions & 6 deletions browser/base/content/test/static/browser_parsable_css.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,6 @@ let ignoreList = [
errorMessage: /Unknown property.*overflow-clip-box/i,
isFromDevTools: false,
},
// Same but with zoom.
{
sourceName: /\bscrollbars\.css$/i,
errorMessage: /Unknown property ‘zoom’/i,
isFromDevTools: false,
},
// These variables are declared somewhere else, and error when we load the
// files directly. They're all marked intermittent because their appearance
// in the error console seems to not be consistent.
Expand All @@ -70,6 +64,14 @@ let ignoreList = [
},
];

if (!Services.prefs.getBoolPref("layout.css.zoom.enabled")) {
ignoreList.push({
sourceName: /\bscrollbars\.css$/i,
errorMessage: /Unknown property ‘zoom’/i,
isFromDevTools: false,
});
}

if (!Services.prefs.getBoolPref("layout.css.color-mix.enabled")) {
// Reserved to UA sheets unless layout.css.color-mix.enabled flipped to true.
ignoreList.push({
Expand Down
2 changes: 1 addition & 1 deletion layout/reftests/transform-3d/backface-visibility-1a.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<head>
</head>
<body>
<div style="transform: rotatex(180deg); -moz-backface-visibility: visible; width: 100px; height: 100px;">
<div style="transform: rotatex(180deg); backface-visibility: visible; width: 100px; height: 100px;">
Test Text
</div>
</body>
Expand Down
2 changes: 1 addition & 1 deletion layout/reftests/transform-3d/backface-visibility-1b.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<head>
</head>
<body>
<div style="transform: rotatex(180deg); -moz-backface-visibility: hidden; width: 100px; height: 100px;">
<div style="transform: rotatex(180deg); backface-visibility: hidden; width: 100px; height: 100px;">
Test Text
</div>
</body>
Expand Down
2 changes: 1 addition & 1 deletion layout/reftests/transform-3d/backface-visibility-1c.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<head>
</head>
<body>
<div style="transform: rotatex(180deg); -moz-backface-visibility: hidden; width: 100px; height: 100px; display: table">
<div style="transform: rotatex(180deg); backface-visibility: hidden; width: 100px; height: 100px; display: table">
Test Text
</div>
</body>
Expand Down
4 changes: 2 additions & 2 deletions layout/reftests/transform-3d/backface-visibility-2-ref.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
position: absolute;
width: 100%;
height: 100%;
-moz-backface-visibility: hidden;
background: red;
backface-visibility: hidden;
background: red;
}
.face.back {
display: block;
Expand Down
2 changes: 1 addition & 1 deletion layout/reftests/transform-3d/backface-visibility-2.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
position: absolute;
width: 100%;
height: 100%;
-moz-backface-visibility: hidden;
backface-visibility: hidden;
background: red;
}
.face.back {
Expand Down
4 changes: 2 additions & 2 deletions modules/libpref/init/StaticPrefList.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8637,7 +8637,7 @@
# Is support for -moz-prefixed transform properties enabled?
- name: layout.css.prefixes.transforms
type: bool
value: true
value: @IS_NOT_NIGHTLY_BUILD@
mirror: always

# Is support for -moz-prefixed transition properties enabled?
Expand Down Expand Up @@ -8798,7 +8798,7 @@
# Support for the css Zoom property.
- name: layout.css.zoom.enabled
type: RelaxedAtomicBool
value: false
value: @IS_NIGHTLY_BUILD@
mirror: always
rust: true

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
[font-size-interpolation-003.html]
expected:
if (os == "linux") and not debug and fission: [OK, CRASH]
if (os == "android") and fission: [TIMEOUT, OK]
prefs: [layout.css.zoom.enabled:false]
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[button-min-width.html]
prefs: [layout.css.zoom.enabled:false]
2 changes: 1 addition & 1 deletion testing/web-platform/meta/resize-observer/observe.html.ini
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[observe.html]
prefs: [layout.css.zoom.enabled:false]
expected:
if (os == "mac") and not debug: [OK, TIMEOUT]
if (os == "android") and fission: [OK, TIMEOUT]
[guard]
expected:
if (os == "mac") and not debug: [PASS, NOTRUN]
Expand Down
1 change: 1 addition & 0 deletions testing/web-platform/meta/resize-observer/svg.html.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[svg.html]
prefs: [layout.css.zoom.enabled:false]
expected:
if (os == "android") and fission: [OK, TIMEOUT]
if (os == "mac") and not debug: [OK, TIMEOUT]
Expand Down

0 comments on commit b863d00

Please sign in to comment.