Input types for query

[olup]

Very interesting project !

I wondered if the generated input types for the "find" query could be better by nested options rather than have a double-dashed option name. IE :

( where : { name : { contains : "john" } } )
rather than
( where : {name__contains : "john" } )

those inputs are generic, like intInput, stringInput, etc...

[vinpac]

You're right on that. I will make this change after I finish the updateOne and updateMany fields I'm working on.

If I move fast enough to finish these two by the end of this week, I will focus on this issue next week.

[olup]

Pretty good ! Cheers on that !

…

On Wed, Jan 29, 2020 at 1:45 PM Vinicius Pacheco Furtado < ***@***.***> wrote: You're right on that. I will make this change after I finish the updateOne and updateMany fields I'm working on. If I move fast enough to finish these two by the end of this week, I will focus on this issue next week. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=ADJFT5ALRJ6IOIWOKWW3DU3RAF25RA5CNFSM4KNAZYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHB67Q#issuecomment-579739518>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJFT5C3N7YZ3GZHET3WCBLRAF25RANCNFSM4KNAZYAQ> .

[olup]

Also, Ideally, `find` query should be paginated in a relay-style schema (I mean, have a `total`, `pageInfo` and `nodes` key) and offer cursor based input type, what do you think ? On Wed, Jan 29, 2020 at 2:17 PM Loup Topalian <loup.topalian@gmail.com> wrote:

…

Pretty good ! Cheers on that ! On Wed, Jan 29, 2020 at 1:45 PM Vinicius Pacheco Furtado < ***@***.***> wrote: > You're right on that. I will make this change after I finish the > updateOne and updateMany fields I'm working on. > > If I move fast enough to finish these two by the end of this week, I will > focus on this issue next week. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#12?email_source=notifications&email_token=ADJFT5ALRJ6IOIWOKWW3DU3RAF25RA5CNFSM4KNAZYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHB67Q#issuecomment-579739518>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADJFT5C3N7YZ3GZHET3WCBLRAF25RANCNFSM4KNAZYAQ> > . >

[thehappycoder]

I like how Prisma generates where types. Let's you combine AND and OR. Very flexible. You should check it out. Can be totally generated with typeorm query builder.

[olup]

Nexus-prisma style graphql api is indeed what I was proposing to reproduce to a certain extent

…

I like how Prisma generates where types. Let's you combine AND and OR. Very flexible. You should check it out. Can be totally generated with typeorm query builder. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=ADJFT5HPF4GQJSAT5BKHTOLRAO24VA5CNFSM4KNAZYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKNR24Y#issuecomment-580590963>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJFT5D57HUCI2FKP5FZISLRAO24VANCNFSM4KNAZYAQ> .

[vinpac]

Nexus prisma is big inspiration for this project indeed!

I'm almosted finished with updateOne, updateMany and it's nested relation mutations. It is being made to have the same mutations as nexus-prisma.

With the updated where types it will work like a charm