Two updates (using Site for domain as doc says, specifying template context) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts.get_current().domain if EMAIL_CONFIRM_LA_DOMAIN isn't set
…on with Postmark)
|
Oh no, CI is failed. |
…to 'example.com'. This happens when running unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README says that if EMAIL_CONFIRM_LA_DOMAIN isn't set, Site.objects.get_current().domain will be used. Code didn't actually do that. EMAIL_CONFIRM_LA_DOMAIN was hardcoded to 'example.com'. Updated to actually use Site.objects.get_current().domain as the default value. If there is an exception (Site isn't being used), will fallback to 'example.com'.
Added ability to send in template context data when using verify_email_for_object(). This function was calling send() which already had the ability to accept template context data (but was never used since verify_email_for_object() never passed any context data through).
Updated README and added unit tests as well.