-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Colab integration #22
Conversation
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 61.22% 61.22%
=======================================
Files 13 13
Lines 1212 1212
=======================================
Hits 742 742
Misses 470 470 Continue to review full report at Codecov.
|
df3b8a9
to
9b3aa4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you please make a Colab for notebooks/End-to-End-Matching-Example.ipynb?
- Please also check all links inside the Colab notebooks.
Also, in the examples section in readme, please make a table like this with colab links: https://github.com/KevinMusgrave/pytorch-metric-learning/blob/master/examples/README.md |
One more thing: is there a way to force Colab to use a GPU? I had to manually use "Change runtime type" to use a GPU. |
Not that I've found, pytorch-metric-learning also asks that we do it manually |
|
Persistence seems to be possible via Google Drive integration https://stackoverflow.com/a/66670818 |
In this case, we can leave the code that saves to Drive commented and put an explanation on the Notebook. |
|
||
Notebook | Description | Google Colab Link | ||
--- | --- | --- | ||
Deduplication Example | For when you have a single dirty dataset with duplicates | [![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/vintasoftware/entity-embed/blob/main/notebooks/google-colab/Deduplication-Example.ipynb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that these urls consider the files already exist on main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.