Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Colab integration #22

Merged
merged 15 commits into from
Apr 29, 2021
Merged

Google Colab integration #22

merged 15 commits into from
Apr 29, 2021

Conversation

rvlb
Copy link
Contributor

@rvlb rvlb commented Apr 13, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #22 (df3b8a9) into main (163c06c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   61.22%   61.22%           
=======================================
  Files          13       13           
  Lines        1212     1212           
=======================================
  Hits          742      742           
  Misses        470      470           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163c06c...df3b8a9. Read the comment docs.

@rvlb rvlb marked this pull request as ready for review April 22, 2021 18:10
@rvlb rvlb requested a review from fjsj April 22, 2021 18:10
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you please make a Colab for notebooks/End-to-End-Matching-Example.ipynb?
  • Please also check all links inside the Colab notebooks.

@fjsj
Copy link
Member

fjsj commented Apr 22, 2021

Also, in the examples section in readme, please make a table like this with colab links: https://github.com/KevinMusgrave/pytorch-metric-learning/blob/master/examples/README.md

@fjsj
Copy link
Member

fjsj commented Apr 22, 2021

One more thing: is there a way to force Colab to use a GPU? I had to manually use "Change runtime type" to use a GPU.

@rvlb
Copy link
Contributor Author

rvlb commented Apr 22, 2021

Not that I've found, pytorch-metric-learning also asks that we do it manually

Our readme: https://github.com/vintasoftware/entity-embed/blob/5f3b34e8b42bbed4f621a1c5a37edf7de75e5509/notebooks/google-colab/README.md

@fjsj
Copy link
Member

fjsj commented Apr 22, 2021

  • Please keep the current descriptions we have in README for the examples.
  • Make a Colab for notebooks/End-to-End-Matching-Example.ipynb. Not sure how to load the model though, maybe we'll have to pre-generate it. Please research if possible to have disk persistence in Colab across Notebooks.
  • If it's not possible to programatically request a GPU, then please add the instruction to the top of the Colab Notebook.

@rvlb
Copy link
Contributor Author

rvlb commented Apr 23, 2021

Persistence seems to be possible via Google Drive integration https://stackoverflow.com/a/66670818

@fjsj
Copy link
Member

fjsj commented Apr 23, 2021

Persistence seems to be possible via Google Drive integration

In this case, we can leave the code that saves to Drive commented and put an explanation on the Notebook.


Notebook | Description | Google Colab Link
--- | --- | ---
Deduplication Example | For when you have a single dirty dataset with duplicates | [![Open In Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/vintasoftware/entity-embed/blob/main/notebooks/google-colab/Deduplication-Example.ipynb)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that these urls consider the files already exist on main.

@rvlb rvlb requested a review from fjsj April 27, 2021 14:54
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjsj fjsj merged commit 4546160 into main Apr 29, 2021
@fjsj fjsj deleted the google-collab-notebooks branch April 29, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants