-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resouce aware get_api_root #156
Comments
Hmm, yes, that's probably a good idea! |
I made a PR #157 with the change and a test to verify it. I've added the parameter with a default to keep backwards compatibility with previous implementations |
Add support to resource aware api_root #156
Merged and published to PyPI as version 1.5.1 |
Is Tapioca following semver? I'm wanting to make sure we have our version constraints set up appropriately. We have our own |
@epage yes we follow semver. That was my mistake, very sorry! I just pulled the version from PyPI. Will fix and make a new release. |
I am implementing a Tapioca Flavour and there are some cases where I need to use a different API root.
Then, checking the code I saw that it could be a solution for these cases to pass to the get_api_root function the resource name at this line:
https://github.com/vintasoftware/tapioca-wrapper/blob/master/tapioca/tapioca.py#L113
So it will help to mount the proper api root url on these cases
The text was updated successfully, but these errors were encountered: