Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resouce aware get_api_root #156

Closed
humrochagf opened this issue Apr 12, 2019 · 5 comments
Closed

Resouce aware get_api_root #156

humrochagf opened this issue Apr 12, 2019 · 5 comments

Comments

@humrochagf
Copy link
Contributor

I am implementing a Tapioca Flavour and there are some cases where I need to use a different API root.

Then, checking the code I saw that it could be a solution for these cases to pass to the get_api_root function the resource name at this line:

https://github.com/vintasoftware/tapioca-wrapper/blob/master/tapioca/tapioca.py#L113

So it will help to mount the proper api root url on these cases

@filipeximenes
Copy link
Contributor

Hmm, yes, that's probably a good idea!

humrochagf added a commit to humrochagf/tapioca-wrapper that referenced this issue Apr 12, 2019
@humrochagf
Copy link
Contributor Author

I made a PR #157 with the change and a test to verify it.

I've added the parameter with a default to keep backwards compatibility with previous implementations

filipeximenes added a commit that referenced this issue Apr 18, 2019
Add support to resource aware api_root #156
@filipeximenes
Copy link
Contributor

filipeximenes commented Apr 18, 2019

Merged and published to PyPI as version 1.5.1

@epage
Copy link

epage commented Apr 18, 2019

Is Tapioca following semver? I'm wanting to make sure we have our version constraints set up appropriately.

We have our own Adapter implementation with its own get_api_root and this change broke our implementation. So either this was (1) unintended, (2) you aren't following semver, or (3) we aren't supposed to override this function.

@filipeximenes
Copy link
Contributor

@epage yes we follow semver. That was my mistake, very sorry! I just pulled the version from PyPI. Will fix and make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants