Fix FinalErrorHandler for error phase #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
When using a
Layer
, an unrecoveredpanic
should cause theFinalErrorHandler
to be use and return a 500 status code with the error message.Actual behavior
The
FinalErrorHandler
was never used if apanic
occured. TheRun
function simply returned without callingserveHTTP
(ref. https://github.com/vinci-proxy/layer/blob/master/layer.go#L143) and therefore simply swallows the panic. @h2non correct me if this was the expected behavior.Additional information
This PR should also increase code coverage.