Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getGroup #42

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Implement getGroup #42

merged 2 commits into from
Mar 18, 2019

Conversation

mitruly
Copy link
Contributor

@mitruly mitruly commented Feb 25, 2019

Implement getGroup method. Resolves #17.

Changes include:

  • Implement getGroup
  • Add tests

Note to reviewers: Tested this against a local instance of VinylDNS:

VinylDNSClient localClient =
    new VinylDNSClientImpl(
        new VinylDNSClientConfig(
            "http://localhost:9000",
            new BasicAWSCredentials("testUserAccessKey", "testUserSecretKey")));

VinylDNSResponse<Group> vinylDNSResponse = localClient.getGroup(new GetGroupRequest("140e108d-0b52-4030-8958-c210ceda9997"));

System.out.println("response: " + vinylDNSResponse);

This resulted in the following response:

response: VinylDNSSuccessResponse{value=Group{name='fsd', email='sdfsd', description='null', id='140e108d-0b52-4030-8958-c210ceda9997', created='2019-02-24T18:49:31.000-05:00', status=Active, memberIds=null, adminUserIds=null}, statusCode=200}

@mitruly mitruly self-assigned this Feb 25, 2019
@mitruly mitruly merged commit 5c51582 into vinyldns:master Mar 18, 2019
@mitruly mitruly deleted the get-group branch March 18, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant