Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow assume role with optional externalId #1123

Closed
wants to merge 5 commits into from

Conversation

pedrokiefer
Copy link
Contributor

Refactor route53 to allow assuming a role, either with the default chain, or using a given key pair.

@CLAassistant
Copy link

CLAassistant commented May 4, 2022

CLA assistant check
All committers have signed the CLA.

@pedrokiefer
Copy link
Contributor Author

@remerle fixed the broken test.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Base: 92.30% // Head: 91.90% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (205fa07) compared to base (f9ee92c).
Patch coverage: 46.66% of modified lines in pull request are covered.

❗ Current head 205fa07 differs from pull request most recent head f6c1ca0. Consider uploading reports for the commit f6c1ca0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
- Coverage   92.30%   91.90%   -0.40%     
==========================================
  Files         173      173              
  Lines        7328     6968     -360     
  Branches      204      176      -28     
==========================================
- Hits         6764     6404     -360     
  Misses        564      564              
Impacted Files Coverage Δ
...nyldns/route53/backend/Route53ProviderConfig.scala 0.00% <ø> (ø)
.../vinyldns/route53/backend/Route53Credentials.scala 38.09% <38.09%> (ø)
...cala/vinyldns/route53/backend/Route53Backend.scala 82.10% <66.66%> (-1.77%) ⬇️
.../vinyldns/api/domain/record/RecordSetService.scala 90.72% <0.00%> (-2.02%) ⬇️
...nyldns/api/domain/batch/BatchChangeConverter.scala 98.30% <0.00%> (-1.70%) ⬇️
...yldns/api/domain/record/RecordSetValidations.scala 95.57% <0.00%> (-1.55%) ⬇️
...ldns/api/domain/membership/MembershipService.scala 94.77% <0.00%> (-1.53%) ⬇️
...main/scala/vinyldns/api/route/JsonValidation.scala 84.61% <0.00%> (-1.10%) ⬇️
modules/portal/app/controllers/VinylDNS.scala 85.64% <0.00%> (-0.86%) ⬇️
...inyldns/mysql/repository/MySqlZoneRepository.scala 96.42% <0.00%> (-0.41%) ⬇️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Aravindh-Raju Aravindh-Raju added the kind/enhancement A modification or enhancement to existing functionality label Sep 11, 2023
Copy link
Member

@Aravindh-Raju Aravindh-Raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out locally. Looks good to me!

@pedrokiefer
Copy link
Contributor Author

I'll close this in favor of #1300, which has signed commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A modification or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants