-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: allow assume role with optional externalId #1123
Conversation
@remerle fixed the broken test. |
Codecov ReportBase: 92.30% // Head: 91.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 92.30% 91.90% -0.40%
==========================================
Files 173 173
Lines 7328 6968 -360
Branches 204 176 -28
==========================================
- Hits 6764 6404 -360
Misses 564 564
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out locally. Looks good to me!
I'll close this in favor of #1300, which has signed commits. |
Refactor route53 to allow assuming a role, either with the default chain, or using a given key pair.